Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
[smcv: fix typo]
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775279
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847366
Applied-upstream: no, GTK+ 4 added a dependency on newer libepoxy instead
Gbp-Pq: Name gdk-x11-Check-if-we-have-access-to-GL-before-using-G.patch
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Loic Minier [Sun, 21 Oct 2007 20:05:42 +0000 (22:05 +0200)]
Don't list images from unknown directories in icon cache
After GTK+ 2.12.0, gtk-update-icon-cache fails if there is a PNG file
placed directly in /usr/share/icons/hicolor (not in a correct
subdirectory like 48x48/apps).
TODO: This is believed to have been fixed differently upstream, so maybe
this change is no longer necessary:
"I believe a slightly different fix that I did some time ago fixes this
too." --Matthias Clasen, 2008-02-16 04:43:10 UTC
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=451634
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=444285
Forwarded: yes
Applied-upstream: no
Ming Hua [Thu, 13 Mar 2008 23:09:25 +0000 (18:09 -0500)]
Do not use VIQR input method for vi locale by default
In the Vietnamese Quoted-Readable input method, punctuation following a
base letter is converted into diacritical marks, for example a( → ă.
(See <https://en.wikipedia.org/wiki/Vietnamese_Quoted-Readable>.)
A 2008 bug report in Ubuntu argued that this is a problematic default,
particularly when typing passwords, where the effect of the punctuation
is non-obvious.
According to the bug reporter, VIQR is popular with Vietnamese users
living elsewhere in the world, where Vietnamese keyboards are unlikely
to be readily available, but is not a popular choice within Vietnam,
where the Telex or VNI input modes are preferred.
[smcv: Add a summary of the Ubuntu bug]
Bug-Debian: https://bugs.debian.org/895043
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/191451
Forwarded: no
Gbp-Pq: Name 022_disable-viqr-im-for-vi-locale.patch
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Simon McVittie [Fri, 6 Apr 2018 10:29:17 +0000 (11:29 +0100)]
m4macros: Set a serial number
When a project has a bundled copy of our macro included in tarball
source releases, typically in a m4/ or aclocal/ directory, aclocal
uses the serial number to determine whether the system copy in
/usr/share/aclocal is newer or older than the bundled copy. Without
a serial number, the bundled copy will always be used and will not
be overwritten, even if it is outdated.
Simon McVittie [Wed, 27 Jun 2018 08:55:28 +0000 (09:55 +0100)]
gtk+3.0 (3.22.30-2) unstable; urgency=medium
* Team upload
[ Jeremy Bicha ]
* Bump minimum wayland-protocols to 1.12
[ Simon McVittie ]
* d/p/m4macros-Set-a-serial-number.patch:
Add patch from upstream to give gtk-3.0.m4 a serial number so that
it will override older copies bundled with other packages, typically
in the m4 directory (GTK+ 3 version of #895018)
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
[smcv: fix typo]
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775279
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847366
Applied-upstream: no, GTK+ 4 added a dependency on newer libepoxy instead
Gbp-Pq: Name gdk-x11-Check-if-we-have-access-to-GL-before-using-G.patch
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Loic Minier [Sun, 21 Oct 2007 20:05:42 +0000 (22:05 +0200)]
Don't list images from unknown directories in icon cache
After GTK+ 2.12.0, gtk-update-icon-cache fails if there is a PNG file
placed directly in /usr/share/icons/hicolor (not in a correct
subdirectory like 48x48/apps).
TODO: This is believed to have been fixed differently upstream, so maybe
this change is no longer necessary:
"I believe a slightly different fix that I did some time ago fixes this
too." --Matthias Clasen, 2008-02-16 04:43:10 UTC
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=451634
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=444285
Forwarded: yes
Applied-upstream: no
Ming Hua [Thu, 13 Mar 2008 23:09:25 +0000 (18:09 -0500)]
Do not use VIQR input method for vi locale by default
In the Vietnamese Quoted-Readable input method, punctuation following a
base letter is converted into diacritical marks, for example a( → ă.
(See <https://en.wikipedia.org/wiki/Vietnamese_Quoted-Readable>.)
A 2008 bug report in Ubuntu argued that this is a problematic default,
particularly when typing passwords, where the effect of the punctuation
is non-obvious.
According to the bug reporter, VIQR is popular with Vietnamese users
living elsewhere in the world, where Vietnamese keyboards are unlikely
to be readily available, but is not a popular choice within Vietnam,
where the Telex or VNI input modes are preferred.
[smcv: Add a summary of the Ubuntu bug]
Bug-Debian: https://bugs.debian.org/895043
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/191451
Forwarded: no
Gbp-Pq: Name 022_disable-viqr-im-for-vi-locale.patch
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Jeremy Bicha [Mon, 16 Apr 2018 23:55:32 +0000 (00:55 +0100)]
gtk+3.0 (3.22.30-1) unstable; urgency=medium
[ Jeremy Bicha ]
* New upstream release
* Drop patches applied in new release (numbered 0009-0016)
[ Simon McVittie ]
* d/p/022_disable-viqr-im-for-vi-locale.patch:
Add reference to Ubuntu bug 191451, summarize the reason why this
is applied, and correctly attribute the patch to Ming Hua
(see #895043)
Helmut Grohne [Mon, 26 Mar 2018 04:28:44 +0000 (06:28 +0200)]
AM_PATH_GTK_3_0: Use AC_PATH_TOOL to find pkg-config
AM_PATH_GTK_3_0 uses AC_PATH_PROG for finding pkg-config. Unfortunately,
that will find the build architecture pkg-config which in turn will miss
the host architecture gtk+3.0. What must be used here is the host
architecture pkg-config and that is found with AC_PATH_TOOL.
Olivier Fourdan [Tue, 30 Jan 2018 12:57:35 +0000 (13:57 +0100)]
wayland: Drop cairo surfaces when withdrawing
If a window is unmapped by the client while gdk is processing updates,
(for example Firefox un-mapping its window on Expose events), the
windowing backend resources might be lost (for example with Wayland)
which can cause a crash in end_paint().
Make sure we drop the cairo surfaces as well when hiding the surface,
that will avoid the crash in gdk_window_impl_wayland_end_paint() when
trying to attach the staging cairo surface to a released wl_surface,
these will be recreated when needed when the surface becomes visible
again and there is no need to keep such buffers around for a surface
which is not visible anyway.
Christoph Reiter [Mon, 19 Mar 2018 17:21:25 +0000 (18:21 +0100)]
gtkstylecontext: guard against gtk_css_widget_node_get_widget() returning NULL in more places
When the widget gets finalized it clears the widgetnode and gtk_css_widget_node_get_widget
returns NULL. Guard against gtk_css_widget_node_get_widget() returning NULL like in other
places.
See https://gitlab.gnome.org/GNOME/pygobject/issues/28#note_82862
Carlos Garnacho [Tue, 20 Mar 2018 14:17:31 +0000 (15:17 +0100)]
imwayland: Avoid TOGGLE_INPUT_PANEL requests if there's no focus
Fixes two things: 1) As GTK+ can be coerced into using the wayland IM
module despite the compositor not implementing the interface, all paths
not checking for global state before sending requests are prone to
crashes, this one fell hit this pitfall.
And 2) ensures the tap gesture only triggers TOGGLE_INPUT_PANEL if the
widget IM is focused. This is a possibility on eg. WebKit pages, where
its IM is only focused as long as a form element in the page is focused.
Tapping elsewhere shouldn't toggle the OSK.
Peter Bloomfield [Mon, 12 Mar 2018 21:46:57 +0000 (17:46 -0400)]
gtkimmodule: make match_backend() query the wayland registry
Wnen _gtk_im_module_get_default_context_id calls
match_backend (context_id) and the default GdkDisplay
is wayland, match_backend() should return TRUE only if
gdk_wayland_display_query_registry (display, "gtk_text_input_manager")
returns TRUE.
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
[smcv: fix typo]
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775279
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847366
Applied-upstream: no, GTK+ 4 added a dependency on newer libepoxy instead
Gbp-Pq: Name gdk-x11-Check-if-we-have-access-to-GL-before-using-G.patch
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Loic Minier [Sun, 21 Oct 2007 20:05:42 +0000 (22:05 +0200)]
Don't list images from unknown directories in icon cache
After GTK+ 2.12.0, gtk-update-icon-cache fails if there is a PNG file
placed directly in /usr/share/icons/hicolor (not in a correct
subdirectory like 48x48/apps).
TODO: This is believed to have been fixed differently upstream, so maybe
this change is no longer necessary:
"I believe a slightly different fix that I did some time ago fixes this
too." --Matthias Clasen, 2008-02-16 04:43:10 UTC
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=451634
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=444285
Forwarded: yes
Applied-upstream: no
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Simon McVittie [Tue, 3 Apr 2018 07:41:09 +0000 (08:41 +0100)]
gtk+3.0 (3.22.29-3) unstable; urgency=medium
* Team upload
* Allow stderr in autopkgtests. They produce harmless diagnostics.
* d/p/0013-wayland-Drop-cairo-surfaces-when-withdrawing.patch:
Add patch from upstream fixing a Wayland client crash if it unmaps
a window while gdk is processing updates
* d/p/0014-AM_PATH_GTK_3_0-Use-AC_PATH_TOOL-to-find-pkg-config.patch,
d/p/0015-m4macros-Fix-underquoting-in-AC_PATH_TOOL.patch:
Use AC_PATH_TOOL to find pkg-config in the deprecated AM_PATH_GTK_3_0
macro (Closes: #894069)
* d/p/0016-imwayland-destroy-objects-only-if-it-matches-our-man.patch:
Add patch proposed upstream to fix crashes on screen blank in some
dual-monitor configurations (Closes: #894388)
Christoph Reiter [Mon, 19 Mar 2018 17:21:25 +0000 (18:21 +0100)]
gtkstylecontext: guard against gtk_css_widget_node_get_widget() returning NULL in more places
When the widget gets finalized it clears the widgetnode and gtk_css_widget_node_get_widget
returns NULL. Guard against gtk_css_widget_node_get_widget() returning NULL like in other
places.
See https://gitlab.gnome.org/GNOME/pygobject/issues/28#note_82862
Carlos Garnacho [Tue, 20 Mar 2018 14:17:31 +0000 (15:17 +0100)]
imwayland: Avoid TOGGLE_INPUT_PANEL requests if there's no focus
Fixes two things: 1) As GTK+ can be coerced into using the wayland IM
module despite the compositor not implementing the interface, all paths
not checking for global state before sending requests are prone to
crashes, this one fell hit this pitfall.
And 2) ensures the tap gesture only triggers TOGGLE_INPUT_PANEL if the
widget IM is focused. This is a possibility on eg. WebKit pages, where
its IM is only focused as long as a form element in the page is focused.
Tapping elsewhere shouldn't toggle the OSK.
Peter Bloomfield [Mon, 12 Mar 2018 21:46:57 +0000 (17:46 -0400)]
gtkimmodule: make match_backend() query the wayland registry
Wnen _gtk_im_module_get_default_context_id calls
match_backend (context_id) and the default GdkDisplay
is wayland, match_backend() should return TRUE only if
gdk_wayland_display_query_registry (display, "gtk_text_input_manager")
returns TRUE.
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
[smcv: fix typo]
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=775279
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847366
Applied-upstream: no, GTK+ 4 added a dependency on newer libepoxy instead
Gbp-Pq: Name gdk-x11-Check-if-we-have-access-to-GL-before-using-G.patch
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Loic Minier [Sun, 21 Oct 2007 20:05:42 +0000 (22:05 +0200)]
Don't list images from unknown directories in icon cache
After GTK+ 2.12.0, gtk-update-icon-cache fails if there is a PNG file
placed directly in /usr/share/icons/hicolor (not in a correct
subdirectory like 48x48/apps).
TODO: This is believed to have been fixed differently upstream, so maybe
this change is no longer necessary:
"I believe a slightly different fix that I did some time ago fixes this
too." --Matthias Clasen, 2008-02-16 04:43:10 UTC
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=451634
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=444285
Forwarded: yes
Applied-upstream: no
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Simon McVittie [Thu, 22 Mar 2018 10:15:24 +0000 (10:15 +0000)]
gtk+3.0 (3.22.29-2) unstable; urgency=medium
* Team upload
* Refresh patch series through gbp-pq
- Harvest date and authorship information from debian/changelog
* Add more upstream status information to the patch series
* d/p/0009-gtkimmodule-make-match_backend-query-the-wayland-reg.patch,
d/p/0010-imwayland-Avoid-TOGGLE_INPUT_PANEL-requests-if-there.patch:
Add patches from upstream fixing Wayland client crashes under
unspecified circumstances (Closes: #893696)
* d/p/0011-gtkstylecontext-guard-against-gtk_css_widget_node_ge.patch:
Add patch from upstream fixing a NULL dereference
* d/p/0012-widget-Only-print-allocation-warnings-with-enable-de.patch:
Add patch from upstream silencing allocation warnings for stable
branches (if there is ever a GTK+ 3.23 then these warnings would
come back until 3.24). (Closes: #867427)
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Jeremy Bicha [Thu, 15 Feb 2018 10:23:44 +0000 (10:23 +0000)]
gtk+3.0 (3.22.28-1) unstable; urgency=medium
* New upstream release (LP: #1698270) (LP: #1714518)
* Update Vcs fields for conversion to git
* Add debian/gbp.conf
* Bump Standards-Version to 4.1.3
* Update Vcs fields for migration to https://salsa.debian.org/
* Drop git_text-view-support-emoji-chooser.patch: Applied in new release
Matthias Clasen [Wed, 22 Nov 2017 21:47:43 +0000 (16:47 -0500)]
text view: Support the Emoji chooser
Similar to GtkEntry, add an "Insert Emoji" context
menu item, and add the same keybindings. We don't
add the icon here, since it is not clear where it
would go.
https://bugzilla.gnome.org/show_bug.cgi?id=790029
Gbp-Pq: Name git_text-view-support-emoji-chooser.patch
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.
Martin Pitt [Thu, 8 Sep 2011 07:14:02 +0000 (09:14 +0200)]
Consistently treat gdkenumtypes.[hc] as source files
Always generate gdk/gdkenumtypes.c in the source tree, and fix path in the
introspection sources. With this, gdkenumtypes.c is correctly included with
separate build trees, too. This fixes missing GTypes in the .gir when using a
separate build tree.
Also remove the gdk/stamp-gdkenumtypes.h target. It was forcing the
regeneration of gdk/gdkenumtypes.h even if it was already present and current
in the source tree.
Jeremy Bicha [Tue, 28 Nov 2017 22:16:13 +0000 (22:16 +0000)]
gtk+3.0 (3.22.26-2) unstable; urgency=medium
[ Simon McVittie ]
* Set Rules-Requires-Root to no
* Add a Lintian override to silence warnings about the non-standard
name of libgail-3-0, which should really have been libgailutil-3-0
but isn't going to be changed now
[ Jeremy Bicha ]
* Add git_text-view-support-emoji-chooser.patch:
- Offer right-click "Insert Emoji" menu item for GtkTextView too
Emmanuele Bassi [Fri, 20 Jan 2017 18:07:01 +0000 (18:07 +0000)]
gdk/x11: Check if we have access to GL before using GLX API
If the platform does not have access to libGL then any call to GL and
GLX API through libepoxy will fail with an assertion. Until such time
that libepoxy exposes API for us to use, we can simply dlopen libGL
ourselves and do a symbol check.
Temporarily disable this test until someone figures out how
to make it run with GTK_CSD=1 properly so it gives output
matching the expected test data in all cases, not just
for installed-tests.